rename executeChildProcessWithPackageManager to executeCommand

aws-amplify · Jan 29, 2024 · a2f0e5a · a2f0e5a
1 parent 33d05dd
commit a2f0e5a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/packages/backend-deployer/src/cdk_deployer.test.ts b/packages/backend-deployer/src/cdk_deployer.test.ts
@@ -34,10 +34,8 @@ void describe('invokeCDKCommand', () => {
     backendLocator,
     packageManagerControllerFactory.getPackageManagerController()
   );
-  const execaMock = mock.method(
-    invoker,
-    'executeChildProcessWithPackageManager',
-    () => Promise.resolve()
+  const execaMock = mock.method(invoker, 'executeCommand', () =>
+    Promise.resolve()
   );
 
   beforeEach(() => {
@@ -271,7 +269,7 @@ void describe('invokeCDKCommand', () => {
   });
 
   void it('returns human readable errors', async () => {
-    mock.method(invoker, 'executeChildProcessWithPackageManager', () => {
+    mock.method(invoker, 'executeCommand', () => {
       throw new Error('Access Denied');
     });
 

diff --git a/packages/backend-deployer/src/cdk_deployer.ts b/packages/backend-deployer/src/cdk_deployer.ts
@@ -74,7 +74,7 @@ export class CDKDeployer implements BackendDeployer {
    * Wrapper for the child process executor. Helps in unit testing as node:test framework
    * doesn't have capabilities to mock exported functions like `execa` as of right now.
    */
-  executeChildProcessWithPackageManager = async (
+  executeCommand = async (
     commandArgs: string[],
     options: { printStdout: boolean } = { printStdout: true }
   ) => {
@@ -131,7 +131,7 @@ export class CDKDeployer implements BackendDeployer {
       return;
     }
     try {
-      await this.executeChildProcessWithPackageManager(
+      await this.executeCommand(
         [
           'tsc',
           '--showConfig',
@@ -145,7 +145,7 @@ export class CDKDeployer implements BackendDeployer {
       return;
     }
     try {
-      await this.executeChildProcessWithPackageManager([
+      await this.executeCommand([
         'tsc',
         '--noEmit',
         '--skipLibCheck',
@@ -228,7 +228,7 @@ export class CDKDeployer implements BackendDeployer {
       cdkCommandArgs.push(...additionalArguments);
     }
 
-    return await this.executeChildProcessWithPackageManager(cdkCommandArgs);
+    return await this.executeCommand(cdkCommandArgs);
   };
 
   private populateCDKOutputFromStdout = async (