Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: decentralize AmplifyErrorTypes #1019

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Conversation

bombguy
Copy link
Contributor

@bombguy bombguy commented Feb 12, 2024

Issue number, if available:
#748

Changes

Problem Decoupling dependency between vertical packages and platform-core for error types.

Corresponding docs PR, if applicable:

Validation

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

changeset-bot bot commented Feb 12, 2024

🦋 Changeset detected

Latest commit: 15a3c53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@aws-amplify/backend-deployer Patch
@aws-amplify/backend-data Patch
@aws-amplify/platform-core Minor
@aws-amplify/backend-cli Patch
@aws-amplify/sandbox Patch
@aws-amplify/backend Patch
@aws-amplify/backend-auth Patch
@aws-amplify/backend-function Patch
@aws-amplify/backend-output-storage Patch
@aws-amplify/backend-secret Patch
@aws-amplify/backend-storage Patch
@aws-amplify/client-config Patch
create-amplify Patch
@aws-amplify/deployed-backend-client Patch
@aws-amplify/auth-construct-alpha Patch
@aws-amplify/model-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bombguy bombguy marked this pull request as ready for review February 12, 2024 19:08
Copy link
Contributor

@edwardfoyle edwardfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple small things

packages/platform-core/src/errors/amplify_error.ts Outdated Show resolved Hide resolved
@bombguy bombguy merged commit 74cbda0 into main Feb 13, 2024
23 of 24 checks passed
@bombguy bombguy deleted the decentralize-error-types branch February 13, 2024 17:53
@sobolk
Copy link
Member

sobolk commented Feb 19, 2024

This is awesome. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants