Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case where tool use does not have input while streaming #2226

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Nov 13, 2024

Problem

Bedrock Tools might be parameterless.

In that case bedrock either returns undefined input or blank.

Changes

Conditionally parse tool input.

Validation

added tests

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk added the run-e2e Label that will include e2e tests in PR checks workflow label Nov 13, 2024
Copy link

changeset-bot bot commented Nov 13, 2024

🦋 Changeset detected

Latest commit: 44455af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/ai-constructs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sobolk sobolk marked this pull request as ready for review November 13, 2024 22:29
@sobolk sobolk requested a review from a team as a code owner November 13, 2024 22:29
@sobolk sobolk merged commit bc6dc69 into main Nov 14, 2024
76 checks passed
@sobolk sobolk deleted the fix-tool-use branch November 14, 2024 00:13
stocaaro added a commit that referenced this pull request Nov 14, 2024
commit d381f73
Author: Aaron S <stocaaro@stocad.com>
Date:   Thu Nov 14 09:37:08 2024 -0600

    feat: Add mis build to the data factory

commit 5d873a1
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Wed Nov 13 16:56:18 2024 -0800

    Version Packages (#2229)

    Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

commit bc6dc69
Author: Kamil Sobol <sobkamil@amazon.com>
Date:   Wed Nov 13 16:13:16 2024 -0800

    Fix case where tool use does not have input while streaming (#2226)

commit 9fd0642
Author: Kamil Sobol <sobkamil@amazon.com>
Date:   Tue Nov 12 13:07:24 2024 -0800

    Add retry mechanism to create amplify e2e test (#2220)

    * Add retry mechanism to create amplify e2e test

    * Add retry mechanism to create amplify e2e test

    * this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-e2e Label that will include e2e tests in PR checks workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants