Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print bootstrap url when browser cannot be opened #2241

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Print bootstrap url when browser cannot be opened #2241

merged 1 commit into from
Nov 18, 2024

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Nov 18, 2024

Problem

There are legit cases when bootstrap url cannot be opened.
E.g.

  • in headless environments
  • if user does not have any app to open URL or lacks permissions to open it
  • if browser crashes

Changes

Catch open errors, eat and log them (as debug logs), print url to the console.

Validation

added test

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

changeset-bot bot commented Nov 18, 2024

🦋 Changeset detected

Latest commit: 09d2549

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/sandbox Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sobolk sobolk marked this pull request as ready for review November 18, 2024 19:34
@sobolk sobolk requested a review from a team as a code owner November 18, 2024 19:34
@sobolk sobolk merged commit 8c8fc5e into main Nov 18, 2024
40 checks passed
@sobolk sobolk deleted the handle_open branch November 18, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants