feat: add data logging api in defineData
#2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolk
reviewed
Dec 19, 2024
Amplifiyer
reviewed
Dec 19, 2024
🦋 Changeset detectedLatest commit: fd2e70e The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sobolk
reviewed
Dec 20, 2024
Co-authored-by: Kamil Sobol <sobkamil@amazon.com>
…kend into data-logging-api
sobolk
approved these changes
Jan 2, 2025
Amplifiyer
approved these changes
Jan 2, 2025
bobbyu99
added a commit
that referenced
this pull request
Jan 2, 2025
* feat: add data logging api to defineData * chore: update API.md * chore: update API.md * addressed PR comments * addressed PR comments * updated ConversationHandlerFunctionLogLevel * chore: update changeset * chore: remove extra changeset * Update .changeset/quick-dingos-whisper.md Co-authored-by: Kamil Sobol <sobkamil@amazon.com> * chore: updated API.md * chore: rename `level` to `fieldLogLevel` * chore: update API.md * chore: bump data-construct version --------- Co-authored-by: Kamil Sobol <sobkamil@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR added data logging options in
defineData. Summary of changes:data-constructversion to consume the new logging apiDataLogLeveltypeDataLogLevelConverterand logging options parserconvertLoggingOptionsToCDKValidation
Unit tests added for:
DataLogLevelConverterconvertLoggingOptionsToCDKdefineDatawith logging optionsChecklist
run-e2elabel set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.