Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling uncaughtException in create-amplify command #2364

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PG-practice
Copy link

Re-open of #2045 because I mistakenly closed it.

Problem

Issue number, if available:
#825

Changes

  1. Add top level error handling with reference to similar fix top-level error handling #865
    In top-level error handling #865, parser and usageDataEmitter appears to be used for subcommands (e.g. ampx sandbox), so omit these parameters because create-amplify command are not followed by subcommands

Corresponding docs PR, if applicable:

Validation

  • error_handler.ts and it's test cases are based on a similar issue fix top-level error handling #865
  • Pressing Ctrl + C during Where should we create your project? prompt causes no error.

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@PG-practice PG-practice requested a review from a team as a code owner December 23, 2024 13:39
Copy link

changeset-bot bot commented Dec 23, 2024

🦋 Changeset detected

Latest commit: 31741ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-amplify Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of duplicating a lot of the code here, you can move the existing error handling from cli package to cli-core package. Both create-amplify and cli have dependencies on the cli-core package.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the diff for this lock file. It should not be needed for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants