Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add deploy test #891

Closed
wants to merge 12 commits into from
Closed

test: add deploy test #891

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7806583
chore: add e2e_flow.test
0618 Jan 9, 2024
5ae2da1
add deploy test but don't work
0618 Jan 9, 2024
2a6a861
Merge branch 'poc/package-manager-support' into poc/pms-deploy-v2
0618 Jan 10, 2024
d3cf45b
comment out deploy test
0618 Jan 10, 2024
590a32c
fix: e2e test assert
0618 Jan 10, 2024
5ef40d1
chore: update package.lock
0618 Jan 10, 2024
93689a0
add deploy test
0618 Jan 10, 2024
b083c3c
use before and after
0618 Jan 10, 2024
9f85439
change amplifyCli to execa
0618 Jan 10, 2024
aa3e912
change test trigger
0618 Jan 10, 2024
4950b7d
Revert "change amplifyCli to execa"
0618 Jan 10, 2024
212c8c1
setupProfile
0618 Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/poc-e2e-flow-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ on: # TODO: need to change the trigger
push:
branches:
- poc/package-manager-support
- poc/pms-deploy-v2
pull_request:
branches:
- poc/package-manager-support
Expand Down Expand Up @@ -61,7 +62,7 @@ jobs:
node-version: ${{ matrix.node-version }}
- name: Restore Build Cache
uses: ./.github/actions/restore_build_cache
- name: Run E2E tests with ${{ matrix.pkg-manager }}
- name: Run E2E flow tests with ${{ matrix.pkg-manager }}
shell: bash
run: |
PACKAGE_MANAGER_EXECUTABLE=${{matrix.pkg-manager}} npm run test:dir packages/integration-tests/src/test-e2e/create_amplify.test.ts
PACKAGE_MANAGER_EXECUTABLE=${{matrix.pkg-manager}} npm run test:dir packages/integration-tests/src/e2e-flow/e2e_flow.test.ts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going for separate test file in separate dir (i.e. not included in e2e run)
then perhaps we could just use this one https://github.com/aws-amplify/amplify-backend/blob/main/packages/integration-tests/src/test-live-dependency-health-checks/health_checks.test.ts
but adapt it to take package manager as input.

Loading
Loading