Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add construct dependencies verification to pr workflow #3066

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

Siqi-Shan
Copy link
Member

@Siqi-Shan Siqi-Shan commented Dec 11, 2024

Description of changes

Add construct dependency verification to PR workflow, instead of only running script in husky commit hooks. With the change dependency verification will be automatic for all PRs.

CDK / CloudFormation Parameters Changed

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Siqi-Shan Siqi-Shan marked this pull request as ready for review December 11, 2024 19:58
@Siqi-Shan Siqi-Shan requested a review from a team as a code owner December 11, 2024 19:58
Copy link
Member

@palpatim palpatim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, assuming there are no node version dependencies we need to worry about

@dpilch
Copy link
Member

dpilch commented Dec 12, 2024

Noting that we can't merge this until #3065 is merged.

@Siqi-Shan
Copy link
Member Author

Merge this PR as dependency verification scripts improv #3078 and dependencies fix #3065 got merged.

@Siqi-Shan Siqi-Shan merged commit 24c82cb into main Dec 16, 2024
6 of 7 checks passed
@Siqi-Shan Siqi-Shan deleted the dep-verification-pr-workflow branch December 16, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants