chore: construct dependencies fix #3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Shan <siqishan@amazon.com>
Signed-off-by: Kevin Shan <siqishan@amazon.com>
palpatim
reviewed
Dec 11, 2024
package.json
Outdated
| @@ -226,6 +226,35 @@ | |||
| "@aws-amplify/graphql-api-construct/@aws-sdk/client-sso", | |||
| "@aws-amplify/graphql-api-construct/@aws-sdk/token-providers", | |||
| "@aws-amplify/graphql-api-construct/semver", | |||
| "@aws-amplify/graphql-api-construct/@aws-cdk/assert", | |||
There was a problem hiding this comment.
nit here and throughout: sort dependency lists
Signed-off-by: Kevin Shan <siqishan@amazon.com>
…s-amplify/auth-construct Signed-off-by: Kevin Shan <siqishan@amazon.com>
Signed-off-by: Kevin Shan <siqishan@amazon.com>
Signed-off-by: Kevin Shan <siqishan@amazon.com>
dpilch
reviewed
Dec 12, 2024
| @@ -24,6 +24,13 @@ const CONSTRUCT_PACKAGE_CONFIGURATIONS: ConstructPackageConfiguration[] = [ | |||
| }, | |||
| ]; | |||
|
|
|||
| const SKIP_TRANSITIVE_REPO_PACKAGES: PackageConfiguration[] = [ | |||
There was a problem hiding this comment.
Is this skipping all transitive deps of @aws-amplify/graphql-conversation-transformer? I think we only want to skip deps that are not used at runtime.
There was a problem hiding this comment.
➕ we should only skip specific packages that we know are ok to skip. Skipping all transitive dependencies of a package is too broad and will allow regressions to sneak in.
2 tasks
dpilch
previously approved these changes
Dec 12, 2024
dpilch
previously approved these changes
Dec 12, 2024
dpilch
approved these changes
Dec 13, 2024
atierian
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add required transitive dependencies to constructs
package.jsondirect dependencies and bundled dependencies. NPM will now correctly install dependency-packages for data construct and api construct with fixedbundledDependencyand generated.jsii. Changes were also made tonohoistin root levelpackage.jsonto fix the dependency chain.This PR also includes changes to bump
aws-cdklib version to v.2.168.0 across packages to correctly resolve deps tree with constructs in Amplify backend.CDK / CloudFormation Parameters Changed
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.