Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generation): remove trailing comma in inferenceConfig resolver code #2933

Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix(generation): remove trailing comma in inferenceConfig resolver code #2933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...y-graphql-api-construct-tests/src/__tests__/generations/graphql/schema-generation.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,12 @@ type Recipe {
}

type Query {
summarize(input: String): String @generation(aiModel: "anthropic.claude-3-haiku-20240307-v1:0", systemPrompt: "summarize the input.")
summarize(input: String): String
@generation(
aiModel: "anthropic.claude-3-haiku-20240307-v1:0"
systemPrompt: "summarize the input."
inferenceConfiguration: { temperature: 0.5 }
)

generateRecipe(description: String): Recipe
@generation(aiModel: "anthropic.claude-3-haiku-20240307-v1:0", systemPrompt: "You are a 3 star michelin chef that generates recipes.")
Expand Down
2 changes: 1 addition & 1 deletion ...ansformer/src/__tests__/__snapshots__/amplify-graphql-generation-transformer.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ export function request(ctx) {
const toolConfig = {"tools":[{"toolSpec":{"name":"responseType","description":"Generate a response type for the given field.","inputSchema":{"json":{"type":"object","properties":{"value":{"type":"string","description":"A UTF-8 character sequence."}},"required":["value"]}}}}],"toolChoice":{"tool":{"name":"responseType"}}};
const prompt = "Generate a string based on the description.";
const args = JSON.stringify(ctx.args);
const inferenceConfig = { inferenceConfig: {"maxTokens":100,"temperature":0.7,"topP":0.9} },;
const inferenceConfig = { inferenceConfig: {"maxTokens":100,"temperature":0.7,"topP":0.9} };

return {
resourcePath: '/model/anthropic.claude-3-haiku-20240307-v1:0/converse',
Expand Down
2 changes: 1 addition & 1 deletion packages/amplify-graphql-generation-transformer/src/resolvers/invoke-bedrock.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const generateResolver = (fileName: string, values: Record<string, string>): str
*/
const getInferenceConfigResolverDefinition = (inferenceConfiguration?: InferenceConfiguration): string => {
return inferenceConfiguration && Object.keys(inferenceConfiguration).length > 0
? `{ inferenceConfig: ${JSON.stringify(inferenceConfiguration)} },`
? `{ inferenceConfig: ${JSON.stringify(inferenceConfiguration)} }`
: 'undefined';
};

Expand Down
Loading