Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant dependencies: @aws-sdk/abort-controller and aws-sdk #3051

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

bobbyu99
Copy link
Contributor

@bobbyu99 bobbyu99 commented Nov 25, 2024

Description of changes

This PR removed redundant dependencies that I previously added in my log config PR.

Removed the following dependencies from packages/amplify-graphql-api-construct-tests:

  • @aws-sdk/abort-controller
  • aws-sdk
CDK / CloudFormation Parameters Changed

Issue #, if available

Description of how you validated changes

E2E

Checklist

  • PR description included
  • yarn test passes
  • E2E test run linked
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Any CDK or CloudFormation parameter changes are called out explicitly

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bobbyu99 bobbyu99 requested a review from a team as a code owner November 25, 2024 23:49
@bobbyu99 bobbyu99 changed the title chore: remove redundant @aws-sdk/abort-controller and aws-sdk chore: remove redundant depencencies: @aws-sdk/abort-controller and aws-sdk Nov 26, 2024
@bobbyu99 bobbyu99 changed the title chore: remove redundant depencencies: @aws-sdk/abort-controller and aws-sdk chore: remove redundant dependencies: @aws-sdk/abort-controller and aws-sdk Nov 26, 2024
@bobbyu99 bobbyu99 enabled auto-merge (squash) November 26, 2024 19:02
@bobbyu99 bobbyu99 merged commit 3c3becc into main Nov 26, 2024
8 checks passed
@bobbyu99 bobbyu99 deleted the remove-abort-controller branch November 26, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants