test: consolidate jest config #3069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpilch
commented
Dec 12, 2024
dpilch
commented
Dec 13, 2024
| @@ -33,38 +33,5 @@ | |||
| "peerDependencies": { | |||
| "aws-cdk-lib": "^2.158.0", | |||
| "constructs": "^10.3.0" | |||
| }, | |||
| "jest": { | |||
There was a problem hiding this comment.
There are no tests in this package.
dpilch
commented
Dec 13, 2024
| @@ -290,7 +290,6 @@ | |||
| "jsii-pacmak": "^1.84.0", | |||
| "jsii-rosetta": "^5.4.23", | |||
| "rimraf": "^3.0.0", | |||
| "ts-jest": "^29.0.0", | |||
There was a problem hiding this comment.
Installed at root level, so it is not needed here or other sub-packages.
dpilch
commented
Dec 13, 2024
There was a problem hiding this comment.
This config was not used because jest is started in each sub-package with lerna run test.
tejas2008
approved these changes
Dec 13, 2024
Siqi-Shan
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Consolidate jest config by:
jest.config.base.jsfile at the rootjest.config.jsin each package in import and extendjest.config.base.jsI did not make any changes to the test config for the E2E tests (which also use jest).
CDK / CloudFormation Parameters Changed
N/A
Issue #, if available
N/A
Description of how you validated changes
Run unit tests
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.