chore[@aws-amplify/graphql-category-api]: suppress reexport and type-only files from coverage metrics #3087
+138
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palpatim
force-pushed
the
palpatim.chore.fix-import-and-type-coverage-metrics
branch
from
62d1217 to
6456512
Compare
… @aws-amplify/graphql-category-api
palpatim
force-pushed
the
palpatim.chore.fix-import-and-type-coverage-metrics
branch
from
6456512 to
acbf9bd
Compare
bobbyu99
reviewed
Dec 19, 2024
| @@ -2,11 +2,4 @@ const baseConfig = require('../../jest.config.base.js'); // eslint-disable-line | |||
|
|
|||
| module.exports = { | |||
| ...baseConfig, | |||
| coverageThreshold: { | |||
There was a problem hiding this comment.
I'm curious why we want to remove the threshold?
There was a problem hiding this comment.
Because we have a global threshold of 90% in jest.config.base.js, from which the package-specific configs extend: https://github.com/aws-amplify/amplify-category-api/blob/main/jest.config.base.js#L16-L21
The overrides were only needed to reduce the threshold in a package where we haven't yet achieved it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Suppress reexport and type-only files from coverage metrics in specified package.
Description of how you validated changes
Local test
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.