fix: double hooks invocation (fixes #9996) #12512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking forward for a solution on this issue :) |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
1
to
16
| import { | ||
| addFunction, | ||
| amplifyPullNonInteractive, | ||
| amplifyPushAuth, | ||
| createNewProjectDir, | ||
| deleteProject, | ||
| deleteProjectDir, | ||
| getAmplifyInitConfig, | ||
| getBackendAmplifyMeta, | ||
| getHooksDirPath, | ||
| gitCleanFdX, | ||
| gitCommitAll, | ||
| gitInit, | ||
| initJSProjectWithProfile, | ||
| nonInteractiveInitWithForcePushAttach, | ||
| } from '@aws-amplify/amplify-e2e-core'; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class
| await gitCleanFdX(projRoot); | ||
|
|
||
| // simulate hosting deployment | ||
| await nonInteractiveInitWithForcePushAttach(projRoot, getAmplifyInitConfig(projRoot, 'integtest')) |
Check notice
Code scanning / CodeQL
Semicolon insertion
lazpavel
approved these changes
Apr 25, 2023
sobolk
approved these changes
Apr 25, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
An error in the logic was causing post-push hooks to be invoked twice in hosting builds.
Issue #, if available
Fixes #9996
Description of how you validated changes
Manually tested both pre and post hooks with
amplify-dev init --envName dev --forcePush --yes, added e2e testChecklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.