Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove smoketest from normal e2e flow #12555

Merged
merged 3 commits into from
May 1, 2023
Merged

fix: remove smoketest from normal e2e flow #12555

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e29084
fix: remove smoketest from normal e2e flow
sdstolworthy May 1, 2023
2d103c0
fix: configure auth for smoketest
sdstolworthy May 1, 2023
6224b3d
Revert "fix: configure auth for smoketest"
sdstolworthy May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/amplify-e2e-tests/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"build-tests": "tsc --build tsconfig.tests.json",
"setup-profile": "ts-node ./src/configure_tests.ts",
"clean-e2e-resources": "ts-node ./src/cleanup-e2e-resources.ts",
"smoketest": "jest --runInBand --testPathPattern='smoketest'"
"smoketest": "npm run setup-profile && jest --runInBand --testPathPattern='smoketest'"
},
"dependencies": {
"@aws-amplify/amplify-category-auth": "3.1.0",
Expand Down
3 changes: 2 additions & 1 deletion scripts/split-e2e-tests-v2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,9 @@ const WINDOWS_SMOKE_TESTS = [
'src/__tests__/schema-iterative-update-1.test.ts',
];
const TEST_EXCLUSIONS: { l: string[]; w: string[] } = {
l: [],
l: ['src/__tests__/smoketest.test.ts'],
w: [
'src/__tests__/smoketest.test.ts',
Comment on lines +102 to +104
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Shouldn't it just work at least on Linux? We run verdaccio when running tests on Linux, freshly built packages would appear as latest there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question as Kamil; is the smoke test failing and leading to this or is some other motive

'src/__tests__/opensearch-simulator/opensearch-simulator.test.ts',
'src/__tests__/storage-simulator/S3server.test.ts',
'src/__tests__/amplify-app.test.ts',
Expand Down