Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add init prompts for Gen2 #13849

Merged
merged 50 commits into from
Sep 20, 2024
Merged

feat: add init prompts for Gen2 #13849

merged 50 commits into from
Sep 20, 2024

Conversation

0618
Copy link
Contributor

@0618 0618 commented Jul 10, 2024 •
edited
Loading

Description of changes

This PR is to add some prompts before a user init a new Gen1 project.

  • If user decide to not continue with Gen1, exit the process.
    Screenshot 2024-07-10 at 16 21 28

  • If user decide to continue with Gen1, ask for the reason

Screenshot 2024-07-10 at 16 22 32

  • Add the reason to project-config.json
Screenshot 2024-07-09 at 17 53 18
  • Add to stack metadata

Screenshot 2024-07-10 at 16 31 26

  • Only show the prompts in a new project.
  • The change doesn't affect headless mode.

Issue #, if available

Description of how you validated changes

  • tested all the scenarios above on my local machine.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@0618 0618 requested a review from a team as a code owner July 10, 2024 01:03
Amplifiyer
Amplifiyer reviewed Jul 10, 2024
View reviewed changes
Copy link
Contributor

@Amplifiyer Amplifiyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be unit tests for this change?

packages/amplify-cli/src/commands/init.ts Outdated Show resolved Hide resolved
packages/amplify-cli/src/init-steps/preInitMigrationWarning.ts Outdated Show resolved Hide resolved
packages/amplify-cli/src/commands/init.ts Outdated Show resolved Hide resolved
0618 and others added 2 commits July 10, 2024 08:58
@awsluja awsluja merged commit 7ab8fae into aws-amplify:dev Sep 20, 2024
5 of 6 checks passed
@0618 0618 deleted the add-init-promps branch September 20, 2024 18:41
sobolk added a commit that referenced this pull request Oct 4, 2024
@sobolk
Revert "feat: add init prompts for Gen2 (#13849)"
c37fe49 
This reverts commit 7ab8fae.
This was referenced Oct 7, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amplifiyer Amplifiyer Amplifiyer left review comments

@edwardfoyle edwardfoyle edwardfoyle left review comments

@swaminator swaminator swaminator left review comments

@awsluja awsluja awsluja approved these changes

@sobolk sobolk sobolk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@0618 @awsluja @swaminator @sobolk @edwardfoyle @Amplifiyer