Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amplify-appsync-simulator): allow null returns in response template #2267

Merged
merged 1 commit into from
Sep 12, 2019

Conversation

yuth
Copy link
Contributor

@yuth yuth commented Sep 12, 2019

Simulator converted falsy results to an empty object which prevented returning null for fields in
connection type and caused graphql validation error when query included a non nullable field

fix #2248

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Simulator converted falsy results to an empty object which prevented returning null for fields in
connection type and caused graphql validation error when query included a non nullable field

fix aws-amplify#2248
Copy link
Contributor

@kaustavghosh06 kaustavghosh06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kaustavghosh06 kaustavghosh06 merged commit 7056250 into aws-amplify:master Sep 12, 2019
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mock: Cannot return null for non-nullable field [Object.id]
2 participants