New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(amplify-category-auth): export lambda trigger roles in template #2894

Merged

kaustavghosh06 merged 2 commits into aws-amplify:master from rowanu:master

Dec 11, 2019

Contributor

rowanu commented Dec 1, 2019

Export execution role so that policies can be associated later. This brings them in line with
function category provider.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.


          feat(amplify-category-auth): export lambda trigger roles in template

22e0eef

Expore execution role so that policies can be associated later. This
brings them in line with function category provider.

re #2303

codecov-io commented Dec 1, 2019 •

edited

Loading

Codecov Report

Merging #2894 into master will increase coverage by 1.8%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #2894     +/-   ##
=========================================
+ Coverage   60.87%   62.68%   +1.8%     
=========================================
  Files         224      219      -5     
  Lines       11495    11164    -331     
  Branches     2253     2174     -79     
=========================================
  Hits         6998     6998             
+ Misses       4189     3858    -331     
  Partials      308      308

Impacted Files	Coverage Δ
...-appsync-simulator/src/data-loader/lambda/index.ts
...plify-appsync-simulator/src/velocity/util/index.ts
...amplify-appsync-simulator/src/data-loader/index.ts
...mplify-appsync-simulator/src/mqtt-server/client.ts
...simulator/src/data-loader/dynamo-db/utils/index.ts
...ackages/amplify-appsync-simulator/src/utils/log.ts
...psync-simulator/src/data-loader/dynamo-db/index.ts
...lify-appsync-simulator/src/velocity/util/errors.ts
...sync-simulator/src/schema/appsync-scalars/index.ts	`0% <0%> (ø)`
...y-appsync-simulator/src/schema/directives/index.ts	`0% <0%> (ø)`
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b518061...61e6faa. Read the comment docs.

gvhuyssteen suggested changes

View reviewed changes

...formation/triggers/CreateAuthChallenge/cloudformation-templates/CreateAuthChallenge.json.ejs Outdated

@@ @@ -191,10 +191,15 @@ @@
                       "Arn": {
                           "Value": {"Fn::GetAtt": ["LambdaFunction", "Arn"]}
                       },
+                      "LambdaExecutionRole": {
+                          "Value: {

gvhuyssteen Dec 5, 2019

Missing closing quotations on Value.

...ils/awscloudformation/triggers/CustomMessage/cloudformation-templates/CustomMessage.json.ejs Outdated

@@ @@ -208,10 +208,15 @@ @@
                       "Arn": {
                           "Value": {"Fn::GetAtt": ["LambdaFunction", "Arn"]}
                       },
+                      "LambdaExecutionRole": {
+                          "Value: {

gvhuyssteen Dec 5, 2019

Missing closing quotations on Value.

...formation/triggers/DefineAuthChallenge/cloudformation-templates/DefineAuthChallenge.json.ejs Outdated

@@ @@ -184,10 +184,15 @@ @@
                       "Arn": {
                           "Value": {"Fn::GetAtt": ["LambdaFunction", "Arn"]}
                       },
+                      "LambdaExecutionRole": {
+                          "Value: {

gvhuyssteen Dec 5, 2019

Missing closing quotations on Value.

...udformation/triggers/PostAuthentication/cloudformation-templates/PostAuthentication.json.ejs Outdated

@@ @@ -184,10 +184,15 @@ @@
                       "Arn": {
                           "Value": {"Fn::GetAtt": ["LambdaFunction", "Arn"]}
                       },
+                      "LambdaExecutionRole": {
+                          "Value: {

gvhuyssteen Dec 5, 2019

Missing closing quotations on Value.

...scloudformation/triggers/PostConfirmation/cloudformation-templates/PostConfirmation.json.ejs Outdated

@@ @@ -191,10 +191,15 @@ @@
                       "Arn": {
                           "Value": {"Fn::GetAtt": ["LambdaFunction", "Arn"]}
                       },
+                      "LambdaExecutionRole": {
+                          "Value: {

gvhuyssteen Dec 5, 2019

Missing closing quotations on Value.

...loudformation/triggers/PreAuthentication/cloudformation-templates/PreAuthentication.json.ejs Outdated

@@ @@ -184,6 +184,11 @@ @@
                     "Arn": {
                         "Value": {"Fn::GetAtt": ["LambdaFunction", "Arn"]}
                     },
+                      "LambdaExecutionRole": {
+                          "Value: {

gvhuyssteen Dec 5, 2019

Missing closing quotations on Value.

...vider-utils/awscloudformation/triggers/PreSignup/cloudformation-templates/PreSignup.json.ejs Outdated

@@ @@ -198,10 +198,15 @@ @@
                       "Arn": {
                           "Value": {"Fn::GetAtt": ["LambdaFunction", "Arn"]}
                       },
+                      "LambdaExecutionRole": {
+                          "Value: {

gvhuyssteen Dec 5, 2019

Missing closing quotations on Value.

...udformation/triggers/PreTokenGeneration/cloudformation-templates/PreTokenGeneration.json.ejs Outdated

@@ @@ -184,6 +184,11 @@ @@
                     "Arn": {
                         "Value": {"Fn::GetAtt": ["LambdaFunction", "Arn"]}
                     },
+                      "LambdaExecutionRole": {
+                          "Value: {

gvhuyssteen Dec 5, 2019

Missing closing quotations on Value.

...rs/VerifyAuthChallengeResponse/cloudformation-templates/VerifyAuthChallengeResponse.json.ejs Outdated

@@ @@ -192,10 +192,15 @@ @@
                       "Arn": {
                           "Value": {"Fn::GetAtt": ["LambdaFunction", "Arn"]}
                       },
+                      "LambdaExecutionRole": {
+                          "Value: {

gvhuyssteen Dec 5, 2019

Missing closing quotations on Value.

Contributor Author

rowanu commented Dec 5, 2019

Ugh, sorry for the copypast 🍝 will fix


          feat: fix copypasta

61e6faa

kaustavghosh06 approved these changes

View reviewed changes

Contributor

kaustavghosh06 left a comment

LGTM.

kaustavghosh06 merged commit 3d07717 into aws-amplify:master

github-actions bot commented May 25, 2021

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet