fix(amplify-codegen-appsync-model-plugin): Support Embeddable Types for iOS #4545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawmicha
commented
Jun 12, 2020
...es/amplify-codegen-appsync-model-plugin/src/__tests__/visitors/appsync-swift-visitor.test.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #4545 +/- ##
==========================================
- Coverage 61.57% 61.17% -0.41%
==========================================
Files 333 333
Lines 14550 14652 +102
Branches 2764 2935 +171
==========================================
+ Hits 8959 8963 +4
- Misses 5164 5245 +81
- Partials 427 444 +17
Continue to review full report at Codecov.
|
|
This pull request introduces 1 alert when merging b9be43b into 2c04c28 - view on LGTM.com new alerts:
|
lawmicha
commented
Jun 12, 2020
| @@ -269,19 +279,17 @@ export class AppSyncSwiftVisitor extends AppSyncModelVisitor { | |||
|
|
|||
| private getSwiftModelTypeName(field: CodeGenField) { | |||
| if (this.isEnumType(field)) { | |||
| const name = this.getEnumName(field.type); | |||
| return field.isList ? `[${name}].self` : `${name}.self`; | |||
| return `${this.getEnumName(field.type)}.self`; | |||
There was a problem hiding this comment.
confirm enum collections
There was a problem hiding this comment.
ran codegen + provisioned API with schema using array of an enum. API calls look good, as long as it is an enum, it will be embedded inside .embedded(type) or .embeddedCollection(of:) when it is an array, without needing square brackets (as removed here)
lawmicha
commented
Jun 12, 2020
|
This pull request introduces 1 alert when merging da1150f into 2c04c28 - view on LGTM.com new alerts:
|
|
in circleCI workflow |
yuth
suggested changes
Jun 15, 2020
| @@ -269,19 +279,17 @@ export class AppSyncSwiftVisitor extends AppSyncModelVisitor { | |||
|
|
|||
| private getSwiftModelTypeName(field: CodeGenField) { | |||
| if (this.isEnumType(field)) { | |||
| const name = this.getEnumName(field.type); | |||
| return field.isList ? `[${name}].self` : `${name}.self`; | |||
| return `${this.getEnumName(field.type)}.self`; | |||
packages/amplify-codegen-appsync-model-plugin/src/visitors/appsync-swift-visitor.ts
Outdated
Show resolved
Hide resolved
packages/amplify-codegen-appsync-model-plugin/src/visitors/appsync-swift-visitor.ts
Outdated
Show resolved
Hide resolved
…sync-swift-visitor.ts Co-authored-by: Yathi <511386+yuth@users.noreply.github.com>
…sync-swift-visitor.ts Co-authored-by: Yathi <511386+yuth@users.noreply.github.com>
|
thanks for reviewing @yuth ! |
lawmicha
changed the title
lawmicha
changed the title
yuth
reviewed
Jun 16, 2020
packages/amplify-codegen-appsync-model-plugin/src/visitors/appsync-swift-visitor.ts
Outdated
Show resolved
Hide resolved
yuth
approved these changes
Jun 16, 2020
…sync-swift-visitor.ts
nikhname
pushed a commit
to nikhname/amplify-cli
that referenced
this pull request
Jul 27, 2020
…or iOS (aws-amplify#4545) - embedded types no longer return encased in square bracket - generate schemas for non models - fix Location Schema test - updated swift presets to generate for all models, including the embedded non-models - Update packages/amplify-codegen-appsync-model-plugin/src/preset.ts - remove unsured hasDirective - rename to Embeddable - Update packages/amplify-codegen-appsync-model-plugin/src/visitors/appsync-swift-visitor.ts Co-authored-by: Yathi <511386+yuth@users.noreply.github.com>
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
customTypetoembedded(type)andembeddedCollection(of)amplify codegen modelsto generate Extensions for embedded typesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.