Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for importing userpool with no appclient secret #6404

Merged
merged 2 commits into from
Jan 20, 2021

Conversation

yuth
Copy link
Contributor

@yuth yuth commented Jan 16, 2021

Update auth import support importing cognito user pool app client (for native) with or without secret. The CLI has been updated (in #6333) to support generation of App client for native not to generate App Secret. By updating the import path, customers can import the auth provisioned by the CLI in a different project.

@yuth yuth requested a review from attilah January 16, 2021 01:31
@yuth yuth requested a review from a team as a code owner January 16, 2021 01:31
@lgtm-com
Copy link

lgtm-com bot commented Jan 16, 2021

This pull request introduces 1 alert when merging f45d055 into 3da53b7 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@yuth yuth force-pushed the auth-import-app-secerte branch from f45d055 to 80d438b Compare January 16, 2021 02:35
@attilah attilah self-assigned this Jan 19, 2021
Copy link
Contributor

@attilah attilah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just fix the typos

@yuth yuth changed the title feat: add support for importing userpool with no appclient secrete feat: add support for importing userpool with no appclient secret Jan 20, 2021
@yuth yuth force-pushed the auth-import-app-secerte branch from 80d438b to 56c36f7 Compare January 20, 2021 21:21
@yuth yuth merged commit 4ce4138 into aws-amplify:master Jan 20, 2021
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants