Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amplify-provider-awscloudformation): use prev deployment vars #6486

Merged
merged 4 commits into from
Jan 28, 2021

Conversation

SwaySway
Copy link
Contributor

create deployment record which includes previously deployed parameters and capabilities - add action
to bubble up error within state machine

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@SwaySway SwaySway requested a review from a team as a code owner January 27, 2021 00:01
@SwaySway SwaySway marked this pull request as draft January 27, 2021 00:02
@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #6486 (e29bcc0) into master (5789b26) will increase coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #6486    +/-   ##
========================================
  Coverage   57.34%   57.34%            
========================================
  Files         474      474            
  Lines       21671    21674     +3     
  Branches     4307     4092   -215     
========================================
+ Hits        12427    12430     +3     
- Misses       8363     8383    +20     
+ Partials      881      861    -20     
Impacted Files Coverage Δ
packages/amplify-cli-core/src/index.ts 94.73% <ø> (ø)
...ormation/src/iterative-deployment/state-machine.ts 100.00% <ø> (ø)
...tion-transformer/src/ModelConnectionTransformer.ts 89.49% <50.00%> (-0.04%) ⬇️
...cloudformation/src/iterative-deployment/helpers.ts 100.00% <100.00%> (ø)
...es/graphql-connection-transformer/src/resources.ts 78.48% <100.00%> (+0.27%) ⬆️
packages/amplify-util-mock/src/api/api.ts 0.00% <0.00%> (ø)
packages/graphql-mapping-template/src/print.ts 35.29% <0.00%> (ø)
packages/amplify-util-mock/src/storage/storage.ts 0.00% <0.00%> (ø)
...ges/amplify-util-mock/src/CFNParser/stack/index.ts 0.00% <0.00%> (ø)
...es/amplify-util-mock/src/api/resolver-overrides.ts 0.00% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e4648c...e29bcc0. Read the comment docs.

create deployment record which includes previously deployed parameters and capabilities - add action
to bubble up error within state machine
updated iterative e2e to check for iam auth when making iterative changes
@SwaySway SwaySway marked this pull request as ready for review January 27, 2021 22:06
@SwaySway SwaySway requested a review from yuth January 27, 2021 22:06
Copy link
Contributor

@yuth yuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge after removing the unused err

@lgtm-com
Copy link

lgtm-com bot commented Jan 28, 2021

This pull request fixes 1 alert when merging a276dfc into 525deb6 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

1 similar comment
@lgtm-com
Copy link

lgtm-com bot commented Jan 28, 2021

This pull request fixes 1 alert when merging a276dfc into 525deb6 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

…oyment/deployment-manager.ts

Co-authored-by: Yathi <511386+yuth@users.noreply.github.com>
@lgtm-com
Copy link

lgtm-com bot commented Jan 28, 2021

This pull request fixes 1 alert when merging e29bcc0 into 525deb6 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@SwaySway SwaySway merged commit 39dfd27 into aws-amplify:master Jan 28, 2021
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants