-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(amplify-provider-awscloudformation): use prev deployment vars #6486
Conversation
3665572
to
4baccdc
Compare
Codecov Report
@@ Coverage Diff @@
## master #6486 +/- ##
========================================
Coverage 57.34% 57.34%
========================================
Files 474 474
Lines 21671 21674 +3
Branches 4307 4092 -215
========================================
+ Hits 12427 12430 +3
- Misses 8363 8383 +20
+ Partials 881 861 -20
Continue to review full report at Codecov.
|
create deployment record which includes previously deployed parameters and capabilities - add action to bubble up error within state machine
updated iterative e2e to check for iam auth when making iterative changes
4baccdc
to
3280215
Compare
packages/amplify-provider-awscloudformation/src/iterative-deployment/deployment-manager.ts
Outdated
Show resolved
Hide resolved
packages/amplify-provider-awscloudformation/src/iterative-deployment/deployment-manager.ts
Outdated
Show resolved
Hide resolved
packages/amplify-provider-awscloudformation/src/iterative-deployment/deployment-manager.ts
Outdated
Show resolved
Hide resolved
packages/amplify-provider-awscloudformation/src/iterative-deployment/deployment-manager.ts
Outdated
Show resolved
Hide resolved
packages/amplify-provider-awscloudformation/src/iterative-deployment/state-machine.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge after removing the unused err
packages/amplify-provider-awscloudformation/src/iterative-deployment/deployment-manager.ts
Outdated
Show resolved
Hide resolved
This pull request fixes 1 alert when merging a276dfc into 525deb6 - view on LGTM.com fixed alerts:
|
1 similar comment
This pull request fixes 1 alert when merging a276dfc into 525deb6 - view on LGTM.com fixed alerts:
|
…oyment/deployment-manager.ts Co-authored-by: Yathi <511386+yuth@users.noreply.github.com>
This pull request fixes 1 alert when merging e29bcc0 into 525deb6 - view on LGTM.com fixed alerts:
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
create deployment record which includes previously deployed parameters and capabilities - add action
to bubble up error within state machine
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.