Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch no updates CFN error and fix CFN poller hang #7548

Merged
merged 2 commits into from
Jun 18, 2021

Conversation

edwardfoyle
Copy link
Contributor

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@edwardfoyle edwardfoyle requested a review from a team as a code owner June 18, 2021 19:59
@codecov-commenter
Copy link

Codecov Report

Merging #7548 (bb1a342) into master (0521fc0) will decrease coverage by 8.31%.
The diff coverage is 59.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7548      +/-   ##
==========================================
- Coverage   61.07%   52.76%   -8.32%     
==========================================
  Files         222      523     +301     
  Lines       11479    26157   +14678     
  Branches     2250     5119    +2869     
==========================================
+ Hits         7011    13802    +6791     
- Misses       4160    11385    +7225     
- Partials      308      970     +662     
Impacted Files Coverage Δ
...psync-simulator/src/data-loader/dynamo-db/index.ts 10.86% <0.00%> (+10.86%) ⬆️
...amplify-appsync-simulator/src/data-loader/index.ts 60.00% <ø> (ø)
...fy-appsync-simulator/src/schema/directives/auth.ts 20.28% <0.00%> (ø)
...ages/amplify-appsync-simulator/src/schema/index.ts 19.40% <0.00%> (ø)
...rver/subscription/mqtt-server/abstract-listener.ts 85.00% <ø> (ø)
...c/server/subscription/mqtt-server/trie-listener.ts 36.66% <ø> (ø)
...ulator/src/server/subscription/mqtt-server/util.ts 33.33% <ø> (ø)
...s/amplify-appsync-simulator/src/type-definition.ts 100.00% <ø> (ø)
...psync-simulator/src/utils/expose-graphql-errors.ts 57.14% <ø> (ø)
...ator/src/server/subscription/mqtt-server/client.ts 8.97% <8.97%> (ø)
... and 546 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a23ab9b...bb1a342. Read the comment docs.

@attilah attilah merged commit 312eec3 into aws-amplify:master Jun 18, 2021
@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Jun 19, 2021
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v5.0.1 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.0.1.

cjihrig pushed a commit to ctjlewis/amplify-cli that referenced this pull request Jul 12, 2021
…7548)

* fix: catch no updates CFN error and fix CFN poller hang

* chore: remove other mentions of persistContext
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants