-
Notifications
You must be signed in to change notification settings - Fork 25
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: sanitize component name before generating statement declarations
- Loading branch information
1 parent
325d369
commit 6c24129
Showing
5 changed files
with
124 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
packages/codegen-ui-react/lib/__tests__/workflow/action.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
/* | ||
Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
Licensed under the Apache License, Version 2.0 (the "License"). | ||
You may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
import { getActionIdentifier } from '../../workflow/action'; | ||
|
||
describe('getActionIdentifier', () => { | ||
test('generates bindings in the happy case', () => { | ||
expect(getActionIdentifier('SubmitButton', 'click')).toMatch('submitButtonClick'); | ||
}); | ||
|
||
test('generates legal bindings for names with special characters', () => { | ||
expect( | ||
getActionIdentifier( | ||
'“Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore.”', | ||
'click', | ||
), | ||
).toMatch('loremipsumdolorsitametconsecteturadipiscingelitseddoeiusmodtemporincididuntutlaboreClick'); | ||
}); | ||
|
||
test('generates legal bindings for names starting with a number', () => { | ||
expect( | ||
getActionIdentifier( | ||
'2“Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore.”', | ||
'click', | ||
), | ||
).toMatch('loremipsumdolorsitametconsecteturadipiscingelitseddoeiusmodtemporincididuntutlaboreClick'); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
packages/codegen-ui/example-schemas/workflow/invalidNameForMethod.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
{ | ||
"id": "1234-5678-9010", | ||
"componentType": "Flex", | ||
"name": "InvalidNameForMethod", | ||
"properties": {}, | ||
"children": [ | ||
{ | ||
"name": "“Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore.”", | ||
"componentType": "Text", | ||
"properties": {}, | ||
"bindingProperties": {}, | ||
"events": { | ||
"click": { | ||
"action": "Amplify.Navigation", | ||
"parameters": { | ||
"type": { | ||
"value": "url" | ||
}, | ||
"url": { | ||
"value": "emails", | ||
"type": "string" | ||
} | ||
} | ||
} | ||
} | ||
} | ||
] | ||
} | ||
|