Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick https://github.com/aws-amplify/amplify-codegen-ui/pull/302 into main #303

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

alharris-at
Copy link
Contributor

Cherry-picking so that we can release with the supported version flag on Monday.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@alharris-at alharris-at requested a review from a team December 10, 2021 22:45
@codecov-commenter
Copy link

Codecov Report

Merging #303 (a8cefbf) into main (8b02361) will decrease coverage by 0.03%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
- Coverage   89.48%   89.45%   -0.04%     
==========================================
  Files          34       36       +2     
  Lines        1217     1223       +6     
  Branches      273      273              
==========================================
+ Hits         1089     1094       +5     
- Misses        125      126       +1     
  Partials        3        3              
Impacted Files Coverage Δ
...ges/codegen-ui/lib/required-dependency-provider.ts 0.00% <0.00%> (ø)
packages/codegen-ui-react/lib/index.ts 100.00% <100.00%> (ø)
...ui-react/lib/react-required-dependency-provider.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b02361...a8cefbf. Read the comment docs.

Copy link
Member

@dpilch dpilch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When squash and merging make sure you use feat: add min required ... so that it will show in our changelog.

@alharris-at alharris-at merged commit 7f08cd9 into main Dec 10, 2021
@alharris-at alharris-at deleted the cherry-pick-version-support branch December 10, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants