Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add min required library versions for generated components #302

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

alharris-at
Copy link
Contributor

Issue #, if available:
https://app.asana.com/0/1201447141707771/1201500361005705/f

Description of changes:
Expose a utility class which will provide the CLI metadata on min required dependencies for generated components.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@alharris-at alharris-at requested a review from a team December 10, 2021 20:33
Copy link
Member

@dpilch dpilch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An uncommon case, but should we use a semantic version range so that @aws-amplify/ui-react@3.0.0 would be invalid?

@codecov-commenter
Copy link

Codecov Report

Merging #302 (d5737c1) into develop (4697b71) will decrease coverage by 0.03%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #302      +/-   ##
===========================================
- Coverage    89.48%   89.45%   -0.04%     
===========================================
  Files           34       36       +2     
  Lines         1217     1223       +6     
  Branches       273      273              
===========================================
+ Hits          1089     1094       +5     
- Misses         125      126       +1     
  Partials         3        3              
Impacted Files Coverage Δ
...ges/codegen-ui/lib/required-dependency-provider.ts 0.00% <0.00%> (ø)
packages/codegen-ui-react/lib/index.ts 100.00% <100.00%> (ø)
...ui-react/lib/react-required-dependency-provider.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4697b71...d5737c1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants