Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add form datamodel to requiredDataModels for renderComponentOnly #815

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

Jshhhh
Copy link
Contributor

@Jshhhh Jshhhh commented Dec 2, 2022

Issue #, if available:

Description of changes:

  • add datamodel to requiredDataModels for renderComponentOnly

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Jshhhh Jshhhh marked this pull request as ready for review December 2, 2022 19:34
@Jshhhh Jshhhh requested a review from a team as a code owner December 2, 2022 19:34
@codecov-commenter
Copy link

Codecov Report

Merging #815 (2e35b0c) into tagged-release/cms-support (609ffc2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                     Coverage Diff                     @@
##           tagged-release/cms-support     #815   +/-   ##
===========================================================
  Coverage                       92.68%   92.68%           
===========================================================
  Files                             116      116           
  Lines                            4604     4605    +1     
  Branches                         1322     1322           
===========================================================
+ Hits                             4267     4268    +1     
  Misses                            318      318           
  Partials                           19       19           
Impacted Files Coverage Δ
.../codegen-ui-react/lib/forms/react-form-renderer.ts 94.24% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 609ffc2...2e35b0c. Read the comment docs.

@Jshhhh Jshhhh merged commit f0d74e5 into tagged-release/cms-support Dec 2, 2022
@Jshhhh Jshhhh deleted the required-data-model branch December 2, 2022 20:04
Jshhhh added a commit that referenced this pull request Dec 6, 2022
Jshhhh added a commit that referenced this pull request Dec 6, 2022
* fix: add importCollection to renderComponentOnly return (#813)

Co-authored-by: David Lopez <lopezbnd@amazon.com>

* fix: add form datamodel to requiredDataModels for renderComponentOnly (#815)

Co-authored-by: Justin Shih <jushih@amazon.com>

Co-authored-by: David Lopez <letsbelopez@gmail.com>
Co-authored-by: David Lopez <lopezbnd@amazon.com>
Co-authored-by: Justin Shih <jushih@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants