fix: add importCollection to renderComponentOnly return #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jshhhh
approved these changes
Dec 2, 2022
hein-j
approved these changes
Dec 2, 2022
lyonsbp
approved these changes
Dec 2, 2022
Jshhhh
pushed a commit
that referenced
this pull request
Dec 6, 2022
Co-authored-by: David Lopez <lopezbnd@amazon.com>
Jshhhh
added a commit
that referenced
this pull request
Dec 6, 2022
* fix: add importCollection to renderComponentOnly return (#813) Co-authored-by: David Lopez <lopezbnd@amazon.com> * fix: add form datamodel to requiredDataModels for renderComponentOnly (#815) Co-authored-by: Justin Shih <jushih@amazon.com> Co-authored-by: David Lopez <letsbelopez@gmail.com> Co-authored-by: David Lopez <lopezbnd@amazon.com> Co-authored-by: Justin Shih <jushih@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
https://app.asana.com/0/1202293561809020/1203468156027560/f
Description of changes:
When rendering component only, the client needs to know what the import alias names are for the required data models. This change adds the import aliases to the requiredDataModels value returned by the renderComponentOnly method, so the client knows which alias to use for the data model.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.