Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove type import if no graphql types file #1040

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Conversation

Jshhhh
Copy link
Contributor

@Jshhhh Jshhhh commented Jul 15, 2023

Problem

if types file is undefined in customer's app, it is importing graphql model types from undefined module

Solution

Remove empty/undefined modules from import collection and change graphQL model type to any

Automated tests

  • Unit tests added/updated
  • E2E tests added/updated
  • N/A - (provide a reason)
  • deferred - (provide GitHub issue for tracking)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Jshhhh Jshhhh requested a review from a team as a code owner July 15, 2023 00:30
@Jshhhh Jshhhh force-pushed the graphql-notypefile branch 2 times, most recently from 688dc0f to 2c05a04 Compare July 19, 2023 21:24
@Jshhhh Jshhhh changed the base branch from tagged-release/graphql-support to main July 19, 2023 21:24
@Jshhhh Jshhhh force-pushed the graphql-notypefile branch from 2c05a04 to 325bf3b Compare July 19, 2023 21:38
@codecov-commenter
Copy link

Codecov Report

Merging #1040 (325bf3b) into main (2e1ce96) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1040   +/-   ##
=======================================
  Coverage   93.90%   93.91%           
=======================================
  Files         124      124           
  Lines        5772     5781    +9     
  Branches     1743     1745    +2     
=======================================
+ Hits         5420     5429    +9     
  Misses        334      334           
  Partials       18       18           
Files Changed Coverage Δ
...eact/lib/forms/form-renderer-helper/type-helper.ts 99.19% <100.00%> (+0.03%) ⬆️
.../codegen-ui-react/lib/forms/react-form-renderer.ts 96.61% <100.00%> (+0.03%) ⬆️
.../codegen-ui-react/lib/imports/import-collection.ts 93.75% <100.00%> (+0.05%) ⬆️
packages/codegen-ui-react/lib/utils/graphql.ts 94.59% <100.00%> (+0.15%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e1ce96...325bf3b. Read the comment docs.

@Jshhhh Jshhhh merged commit ac7836a into main Jul 19, 2023
@Jshhhh Jshhhh deleted the graphql-notypefile branch July 19, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants