fix: fix add button disabled state on validation failure #1076
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fix #961
Solution
We should not disabled the
Add
button when validation fails and instead invokerunValidation
again when adding a new item to refresh the error state. That way a user will be able to add the missing field by clicking the button straight without having to clear the input or type in something to refresh before adding a value.Additional Notes
Links
Ticket
GitHub issue:
Other links
Verification
Manual tests
Automated tests
Housekeeping
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.