Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update dependency versioning helpers #1099

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

letsbelopez
Copy link
Contributor

Problem

We need to add and update our current versioning helpers to eventually support amplify js v6 breaking changes.

Solution

Update the required dependency provider.

Add helper functions to know which version of amplify js v6 to render.

Additional Notes

Links

Ticket

GitHub issue:

Other links

Verification

Manual tests

Automated tests

  • Unit tests added/updated
  • E2E tests added/updated
  • N/A - (provide a reason)
  • deferred - (provide GitHub issue for tracking)

Housekeeping

  • No non-essential console logs
  • All new files contain license notice

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@letsbelopez letsbelopez requested a review from a team as a code owner September 28, 2023 18:21
@letsbelopez letsbelopez force-pushed the amplify-js-versioning-helpers branch 3 times, most recently from 626a110 to 4baf814 Compare September 28, 2023 19:03
@letsbelopez letsbelopez force-pushed the amplify-js-versioning-helpers branch from 4baf814 to cd9ed26 Compare September 28, 2023 19:06
@codecov-commenter
Copy link

Codecov Report

Merging #1099 (cd9ed26) into main (7cf4c4b) will decrease coverage by 0.02%.
The diff coverage is 92.30%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1099      +/-   ##
==========================================
- Coverage   93.93%   93.92%   -0.02%     
==========================================
  Files         124      125       +1     
  Lines        5887     5925      +38     
  Branches     1799     1812      +13     
==========================================
+ Hits         5530     5565      +35     
- Misses        339      341       +2     
- Partials       18       19       +1     
Files Coverage Δ
...ges/codegen-ui-react/lib/imports/import-mapping.ts 100.00% <100.00%> (ø)
...ui-react/lib/react-required-dependency-provider.ts 100.00% <100.00%> (ø)
packages/codegen-ui-react/lib/utils/constants.ts 100.00% <100.00%> (ø)
...ges/codegen-ui/lib/required-dependency-provider.ts 0.00% <ø> (ø)
...egen-ui-react/lib/helpers/amplify-js-versioning.ts 89.28% <89.28%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cf4c4b...cd9ed26. Read the comment docs.

@letsbelopez letsbelopez merged commit f848597 into main Sep 28, 2023
5 checks passed
@letsbelopez letsbelopez deleted the amplify-js-versioning-helpers branch September 28, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants