Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export declaration filename helper #1109

Merged
merged 1 commit into from
Oct 17, 2023
Merged

feat: export declaration filename helper #1109

merged 1 commit into from
Oct 17, 2023

Conversation

sdstolworthy
Copy link
Contributor

Problem

This helper is used in external packages to derive the correct declaration filename of a generated component file.

Solution

Additional Notes

Links

Ticket

GitHub issue:

Other links

Verification

Manual tests

Automated tests

  • Unit tests added/updated
  • E2E tests added/updated
  • N/A - (provide a reason)
  • deferred - (provide GitHub issue for tracking)

Housekeeping

  • No non-essential console logs
  • All new files contain license notice

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #1109 (ba2919e) into main (a3ba324) will increase coverage by 0.00%.
Report is 28 commits behind head on main.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1109   +/-   ##
=======================================
  Coverage   93.88%   93.89%           
=======================================
  Files         124      124           
  Lines        5842     5843    +1     
  Branches     1775     1775           
=======================================
+ Hits         5485     5486    +1     
  Misses        339      339           
  Partials       18       18           
Files Coverage Δ
packages/codegen-ui-react/lib/index.ts 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3ba324...ba2919e. Read the comment docs.

@Jshhhh Jshhhh merged commit de1039c into main Oct 17, 2023
5 checks passed
@Jshhhh Jshhhh deleted the filename-helper branch October 17, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants