Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove aws-amplify dependency #1123

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix: remove aws-amplify dependency #1123

merged 1 commit into from
Oct 23, 2023

Conversation

Jshhhh
Copy link
Contributor

@Jshhhh Jshhhh commented Oct 23, 2023

Problem

remove ui hooks from codegen-react

@Jshhhh Jshhhh requested a review from a team as a code owner October 23, 2023 18:06
Milan-Shah
Milan-Shah previously approved these changes Oct 23, 2023
@sdstolworthy
Copy link
Contributor

@Jshhhh when doing a reset locally against the last known good commit, de1039cbeb8671972a67b28d30dcb5d7c0a87796, I see a difference in the golden files that are not represented in this PR: packages/codegen-ui-react/lib/__tests__/__snapshots__/studio-ui-codegen-react-views.test.ts.snap.

 import {
   createDataStorePredicate,
+  formatter,
   useDataStoreBinding,
-} from \\"@aws-amplify/ui-react/internal\\";
+} from \\"./utils\\";
+import { Post } from \\"../models\\";

@Jshhhh Jshhhh merged commit dd7a773 into main Oct 23, 2023
5 checks passed
@Jshhhh Jshhhh deleted the remove-amplify-deps branch October 23, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants