fix: added operand type to ConditionalStudioComponentProperty #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpranoto-aws
force-pushed
the
added-operandtype
branch
from
dac16b2 to
d6a3b8e
Compare
alharris-at
reviewed
Jan 12, 2022
| } from '../react-component-render-helper'; | ||
|
|
||
| import { assertASTMatchesSnapshot } from './__utils__/snapshot-helpers'; | ||
|
|
||
| Error.stackTraceLimit = Infinity; |
There was a problem hiding this comment.
Can probably remove this.
| default: | ||
| return factory.createStringLiteral(operand); |
There was a problem hiding this comment.
I think I'd prefer to leave this behavior as-is for now. Is there a need to change this?
There was a problem hiding this comment.
default behavior restored. There was no particular need for the change
| return valueToJsxLiteral(operand); | ||
| } | ||
|
|
||
| function valueToCorrectLiteral(value: any, valueType: string): PrimaryExpression { |
There was a problem hiding this comment.
perhaps rename to typedValueToLiteral?
There was a problem hiding this comment.
fixed naming to distinguish between the two functions better
kpranoto-aws
force-pushed
the
added-operandtype
branch
from
d6a3b8e to
127b66f
Compare
alharris-at
approved these changes
Jan 12, 2022
|
Looks good Kevin, once our functional tests complete I'll merge into |
alharris-at
approved these changes
Jan 13, 2022
This was referenced Feb 17, 2022
Closed
Merged
alharris-at
pushed a commit
that referenced
this pull request
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: