feat: add mutations #371
Merged
feat: add mutations #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpilch
force-pushed
the
workflow/mutation
branch
2 times, most recently
from
f251c90 to
0e1becb
Compare
dpilch
force-pushed
the
workflow/mutation
branch
from
0e1becb to
060edea
Compare
alharris-at
reviewed
Jan 31, 2022
| .map(([key]) => | ||
| buildOpeningElementEvents( | ||
| { bindingEvent: getSetStateName({ componentName: this.component.name || '', property: key }) }, | ||
| 'change', // TODO: use component event mapping |
There was a problem hiding this comment.
Is there a usecase where this isn't going to be change? I'm thinking TextField, CheckBoxField, etc. are all basically just listening to the value 'change' event. It doesn't make sense for this to be applied to anything that isn't a field, right?
alharris-at
force-pushed
the
workflow/mutation
branch
from
6e00000 to
73f4371
Compare
alharris-at
approved these changes
Jan 31, 2022
Codecov Report
@@ Coverage Diff @@
## tagged-release/q1-release #371 +/- ##
=============================================================
- Coverage 93.35% 93.10% -0.26%
=============================================================
Files 39 40 +1
Lines 1460 1566 +106
Branches 317 339 +22
=============================================================
+ Hits 1363 1458 +95
- Misses 95 106 +11
Partials 2 2
Continue to review full report at Codecov.
|
This was referenced Feb 17, 2022
Closed
Merged
alharris-at
added a commit
that referenced
this pull request
Feb 24, 2022
* feat: add mutation types * feat: mutations * fix: add properties check to address failing integ test * chore: update types and remove replacing flat call with flatMap Co-authored-by: Alexander Harris <alharris@amazon.com>
alharris-at
added a commit
that referenced
this pull request
Feb 25, 2022
* feat: add mutation types * feat: mutations * fix: add properties check to address failing integ test * chore: update types and remove replacing flat call with flatMap Co-authored-by: Alexander Harris <alharris@amazon.com>
alharris-at
added a commit
that referenced
this pull request
Feb 25, 2022
* feat: add mutation types * feat: mutations * fix: add properties check to address failing integ test * chore: update types and remove replacing flat call with flatMap Co-authored-by: Alexander Harris <alharris@amazon.com>
alharris-at
added a commit
that referenced
this pull request
Feb 25, 2022
* feat: add mutation types * feat: mutations * fix: add properties check to address failing integ test * chore: update types and remove replacing flat call with flatMap Co-authored-by: Alexander Harris <alharris@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.