Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow/toggle events #390

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

alharris-at
Copy link
Contributor

Issue #, if available:
N/A

Description of changes:
Adding custom handling for CheckboxField and SwitchField, they're still not quite working correctly, but I'm going to review the behavior w/ the UI team via this PR.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@alharris-at alharris-at requested a review from a team February 9, 2022 05:36
@alharris-at alharris-at changed the base branch from tagged-release/q1-release to workflow/syntheticChangeProps February 9, 2022 05:36
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2022

Codecov Report

Merging #390 (33e5adc) into tagged-release/q1-release (60fa012) will increase coverage by 0.07%.
The diff coverage is 96.96%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##           tagged-release/q1-release     #390      +/-   ##
=============================================================
+ Coverage                      93.66%   93.73%   +0.07%     
=============================================================
  Files                             43       43              
  Lines                           1641     1661      +20     
  Branches                         353      359       +6     
=============================================================
+ Hits                            1537     1557      +20     
  Misses                           102      102              
  Partials                           2        2              
Impacted Files Coverage Δ
...ges/codegen-ui-react/lib/imports/import-mapping.ts 100.00% <ø> (ø)
packages/codegen-ui-react/lib/primitive.ts 100.00% <ø> (ø)
...s/codegen-ui-react/lib/react-component-renderer.ts 86.53% <50.00%> (+0.26%) ⬆️
...eact/lib/react-component-with-children-renderer.ts 95.45% <100.00%> (+0.06%) ⬆️
packages/codegen-ui-react/lib/workflow/events.ts 93.10% <100.00%> (+1.79%) ⬆️
packages/codegen-ui-react/lib/workflow/mutation.ts 98.00% <100.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cc4ce1...33e5adc. Read the comment docs.

Base automatically changed from workflow/syntheticChangeProps to tagged-release/q1-release February 9, 2022 16:39
@alharris-at alharris-at force-pushed the workflow/toggleEvents branch from 02bcb3a to 33e5adc Compare February 9, 2022 16:49
@alharris-at alharris-at force-pushed the workflow/toggleEvents branch from 33e5adc to f924648 Compare February 9, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants