fix: get grand child from component tree #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alharris-at
approved these changes
Feb 9, 2022
Codecov Report
@@ Coverage Diff @@
## tagged-release/q1-release #394 +/- ##
=============================================================
+ Coverage 93.71% 93.77% +0.05%
=============================================================
Files 43 43
Lines 1656 1655 -1
Branches 357 357
=============================================================
Hits 1552 1552
+ Misses 102 101 -1
Partials 2 2
Continue to review full report at Codecov.
|
This was referenced Feb 17, 2022
Closed
Merged
alharris-at
pushed a commit
that referenced
this pull request
Feb 24, 2022
* fix: get grand child from component tree * test: add snapshot
alharris-at
pushed a commit
that referenced
this pull request
Feb 25, 2022
* fix: get grand child from component tree * test: add snapshot
alharris-at
pushed a commit
that referenced
this pull request
Feb 25, 2022
* fix: get grand child from component tree * test: add snapshot
alharris-at
pushed a commit
that referenced
this pull request
Feb 25, 2022
* fix: get grand child from component tree * test: add snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getComponentFromComponentTree would fail for grandchild case. The
.findwould cause the parent of the grand child to be returned in place because.find. Change this to a map and then find on the mapped values fixes this.