-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for "belongsTo" relationships for create forms #755
Conversation
This pull request introduces 1 alert when merging 67d905e into f63a424 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 8ecda9e into f63a424 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
This pull request introduces 1 alert when merging 25daa7c into f63a424 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
Codecov Report
@@ Coverage Diff @@
## tagged-release/cms-support #755 +/- ##
===========================================================
Coverage 92.05% 92.05%
===========================================================
Files 114 114
Lines 4204 4204
Branches 1164 1163 -1
===========================================================
Hits 3870 3870
Misses 313 313
Partials 21 21
Continue to review full report at Codecov.
|
packages/codegen-ui-react/lib/__tests__/studio-ui-codegen-react-forms.test.ts
Outdated
Show resolved
Hide resolved
packages/codegen-ui-react/lib/__tests__/studio-ui-codegen-react-forms.test.ts
Show resolved
Hide resolved
packages/codegen-ui/lib/generate-form-definition/helpers/model-fields-configs.ts
Show resolved
Hide resolved
packages/codegen-ui-react/lib/forms/form-renderer-helper/all-props.ts
Outdated
Show resolved
Hide resolved
packages/codegen-ui-react/lib/forms/form-renderer-helper/event-handler-props.ts
Show resolved
Hide resolved
This pull request introduces 1 alert when merging 8ce437a into f63a424 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
This pull request introduces 1 alert when merging 2d428b2 into f63a424 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
* feat: wip belongs to support * feat: belongsTo working for create form * chore: add golden file for belongsTo create form * fix: arrayfield/autocomplete bugs * chore: update snapshots * chore: handle review comments * chore: add tests and update snapshots
* feat: init form support for has-one relationship (#718) Co-authored-by: Hein Jeong <heinje@amazon.com> * chore: wrap relationship fields in ArrayField (#719) Co-authored-by: Hein Jeong <heinje@amazon.com> * chore: split up form-renderer-helper (#720) Co-authored-by: Hein Jeong <heinje@amazon.com> * chore: map props on relationship-based Autocomplete (#721) Co-authored-by: Hein Jeong <heinje@amazon.com> * feat: add relationship suggestion query to forms (#722) * feat: add relationship suggestion query * chore: map props on relationship-based Autocomplete (#721) Co-authored-by: Hein Jeong <heinje@amazon.com> * feat: add relationship suggestion query * fix: remove extra declarations Co-authored-by: Scott Young <scoyou@amazon.com> Co-authored-by: Hein Jeong <73264629+hein-j@users.noreply.github.com> Co-authored-by: Hein Jeong <heinje@amazon.com> * fix: hide cancel button by default (#696) * chore: modify ArrayField to support has-one relationships (#724) Co-authored-by: Hein Jeong <heinje@amazon.com> * chore: support not-model HAS_ONE relationships (#726) Co-authored-by: Hein Jeong <heinje@amazon.com> * chore: map type file for model fields (#727) Co-authored-by: Hein Jeong <heinje@amazon.com> * feat: add handling for excluded sectional elements * fix: cli test fix * fix: handle association breaking changes for new schema * Add support for "belongsTo" relationships for create forms (#755) * feat: wip belongs to support * feat: belongsTo working for create form * chore: add golden file for belongsTo create form * fix: arrayfield/autocomplete bugs * chore: update snapshots * chore: handle review comments * chore: add tests and update snapshots * feat: adding many to many support for form creation * test: fix tests * test: fix test * feat: adding many-to-many relationship create form golden file * chore: update create file * test: fix test * test: fix unit tests * test: fix tests * fix: fix merge conflicts * test: fix timestamp type * chore: add tag update form golden file with manyToMany relationship Co-authored-by: Hein Jeong <73264629+hein-j@users.noreply.github.com> Co-authored-by: Hein Jeong <heinje@amazon.com> Co-authored-by: Scott Young <snyoung@gmail.com> Co-authored-by: Scott Young <scoyou@amazon.com> Co-authored-by: Josue Ruiz <7465495+SwaySway@users.noreply.github.com> Co-authored-by: Roshane Pascual <rotp@amazon.com> Co-authored-by: Brandon Lyons <lyonsbp@amazon.com>
Issue #, if available:
Description of changes:
This change supports "belongsTo" relationships for forms, putting an
<Autocomplete>
field into the form allowing one related model to be selected.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.