Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update imports and props for aliased components #868

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Conversation

rtpascual
Copy link
Contributor

@rtpascual rtpascual commented Jan 3, 2023

Issue #, if available:

Description of changes:

  • Alias import to match aliased component type from original component. Example: import { Grid as GridCustom } from "./Grid"
  • Point props import to original component - import { GridProps } from "./Grid" instead of import { GridCustomProps } from "./GridCustom"

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #868 (122dc58) into main (47b179b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #868   +/-   ##
=======================================
  Coverage   92.82%   92.83%           
=======================================
  Files         115      115           
  Lines        4807     4813    +6     
  Branches     1377     1379    +2     
=======================================
+ Hits         4462     4468    +6     
  Misses        326      326           
  Partials       19       19           
Impacted Files Coverage Δ
...-react/lib/amplify-ui-renderers/customComponent.ts 100.00% <100.00%> (ø)
packages/codegen-ui-react/lib/helpers/index.ts 100.00% <100.00%> (ø)
...gen-ui-react/lib/react-studio-template-renderer.ts 91.82% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47b179b...122dc58. Read the comment docs.

@rtpascual rtpascual marked this pull request as ready for review January 3, 2023 22:35
@rtpascual rtpascual requested a review from a team as a code owner January 3, 2023 22:35
hein-j
hein-j previously approved these changes Jan 3, 2023
Jshhhh
Jshhhh previously approved these changes Jan 3, 2023
@Jshhhh Jshhhh self-requested a review January 3, 2023 23:21
@rtpascual rtpascual dismissed stale reviews from Jshhhh and hein-j via 21c3bf6 January 4, 2023 18:12
@rtpascual rtpascual merged commit 7c5138a into main Jan 4, 2023
@rtpascual rtpascual deleted the alias-imports branch January 4, 2023 19:03
scottyoung pushed a commit that referenced this pull request Jan 9, 2023
* fix: update imports and props for aliased components

* test: update tests for type declarations and same name validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants