Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: concatenation binding implementation #99

Merged
merged 1 commit into from
Sep 29, 2021
Merged

feat: concatenation binding implementation #99

merged 1 commit into from
Sep 29, 2021

Conversation

frimfram
Copy link
Contributor

Description of changes:

  • Added types for concatenation and conditional
  • Implemented generation of JSX attributes based on "concat" properties

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@frimfram frimfram requested review from dpilch and cwoolum September 29, 2021 22:21
cwoolum
cwoolum approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@cwoolum cwoolum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frimfram frimfram removed the request for review from dpilch September 29, 2021 22:47
@frimfram frimfram merged commit 1bfd428 into main Sep 29, 2021
@frimfram frimfram deleted the add-concat branch September 29, 2021 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwoolum cwoolum cwoolum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frimfram @cwoolum