feat: add e2e tests for codegen add when in a non-amplify project #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronZyLee
reviewed
Sep 18, 2023
| expect(existsSync(userSourceCodePath)).toBe(true); | ||
| // GraphQL statements are generated | ||
| const generatedStatementFiles = new Set(readdirSync(path.join(projectRoot, config.graphqlCodegenDir))); | ||
| console.log(`Comparing written files: ${JSON.stringify(Array.from(generatedStatementFiles))} to expected files: ${JSON.stringify(expectedFilenames)}`); |
There was a problem hiding this comment.
Do we need to log both arrays here as they are compared on the next line?
There was a problem hiding this comment.
Yeah, this'll make debugging easier because the comparison line below fails w/ no indication of what the mismatch was,.
|
|
||
| // GraphQL statements are regenerated | ||
| const regeneratedStatementFiles = new Set(readdirSync(path.join(projectRoot, config.graphqlCodegenDir))); | ||
| console.log(`Comparing written files: ${JSON.stringify(Array.from(regeneratedStatementFiles))} to expected files: ${JSON.stringify(expectedFilenames)}`); |
|
|
||
| // GraphQL statements are regenerated | ||
| const regeneratedStatementFiles = new Set(readdirSync(path.join(projectRoot, config.graphqlCodegenDir))); | ||
| console.log(`Comparing written files: ${JSON.stringify(Array.from(regeneratedStatementFiles))} to expected files: ${JSON.stringify(expectedFilenames)}`); |
There was a problem hiding this comment.
I've pulled this into a utility method to reduce the duplication in this function.
alharris-at
force-pushed
the
noinit-codegen-e2e-tests
branch
from
1e421b6 to
60c1225
Compare
dpilch
approved these changes
Sep 19, 2023
2 tasks
alharris-at
added a commit
that referenced
this pull request
Sep 19, 2023
…set up locally. (#702) * feat: codegen add --region (#683) * fix: download introspection schema when apiId is passed (#684) * fix: codegen --apiId broken state (#689) * chore: get existing e2e tests passing (#704) * feat: add e2e tests for codegen add when in a non-amplify project (#705) * feat: add e2e tests for codegen add when in a non-amplify project * chore: add some additional test cases * noinit codegen from graphqlconfig (#706) * fix: add missing awaits * chore: fail typegen if no queries are found --------- Co-authored-by: Dane Pilcher <dppilche@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added e2e test cases for codegen add in an uninitialized project. These don't yet include test cases where we download an existing api sdl schema.
Issue #, if available
N/A
Description of how you validated changes
E2E Tests pass
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.