-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add angular codegen v6 support #799
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We previously had tests for when this new config property is undefined and we added unit tests for V6, can you also add a test when it's set to v5?
Could you provide an estimate on when the team plans to review and potentially merge this code? It would be helpful for those of us interested in the feature to have an idea of the timeline. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Giving admin approval for API.md
changes, did not review the rest of the PR
Description of changes
Added angular codegen support for JS V6
The new users will have the
amplifyJsLibraryVersion
with default value as6
in their.graphqlconfig.yml
file when runningamplify codegen add
and selecting theangular
target.The old v5 angular users are not impacted as the config file is not modified. To opt-in the new codegen, they can run
amplify codegen remove
andamplify codegen add
with the sameangular
option as target.The old v5 angular is still available by editing the
.graphqlconfig.yml
file to switch theamplifyJsLibraryVersion
from6
to5
.The other inputs in this field are invalid with warning message and will fall into the v6 codegen behavior.
Changes for angular codegen v6 include:
aws-amplify/api
andrxjs
generateClient
to execute APIsCodegen Paramaters Changed or Added
New target
angularv6
in typegenIssue #, if available
Fix #783
Description of how you validated changes
Checklist
yarn test
passespath
) behave differently on windows.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.