fix: include custom conversation handlers in lambdaFunctions for downstream processing #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 10f96d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
7 tasks
svidgen
previously approved these changes
Oct 4, 2024
stocaaro
previously approved these changes
Oct 4, 2024
atierian
force-pushed
the
ai.function-map-conversation-handler
branch
from
2312786 to
7be441b
Compare
Good call, thanks. Addressed in 7be441b |
svidgen
approved these changes
Oct 4, 2024
stocaaro
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Context
a.conversation({ })schema definitions optionally allow ahandlerto be included. This is for some advanced use cases like custom tools within the Lambda function.Problem
Custom conversation handlers aren't correctly referenced in the Data construct because they're not included in the function map passed from data-schema --> backend-data --> data-construct
Change
The Data construct needs to reference the custom handler Lambda function to create the AppSync data source.
defineFunction+a.handler.functiondo this today by keeping a map offunction-name-->DefineFunction, which gets passed to backend-data, then ultimately to the Data construct.This PR adopts that same methodology for custom conversation handlers.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.