feat(auth): enables custom auth flows #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnys1
reviewed
Mar 8, 2022
packages/auth/amplify_auth_cognito/example/integration_test/sign_in_sign_out_test.dart
Outdated
Show resolved
Hide resolved
...oid/src/main/kotlin/com/amazonaws/amplify/amplify_auth_cognito/types/FlutterSignInRequest.kt
Show resolved
Hide resolved
packages/auth/amplify_auth_cognito/example/integration_test/sign_in_sign_out_test.dart
Outdated
Show resolved
Hide resolved
packages/auth/amplify_auth_cognito_ios/ios/Classes/FlutterSignInRequest.swift
Show resolved
Hide resolved
haverchuck
force-pushed
the
feat/custom-auth/no-validation
branch
2 times, most recently
from
0b23781 to
bfdc7c2
Compare
added 19 commits
May 7, 2022 16:48
haverchuck
force-pushed
the
feat/custom-auth/no-validation
branch
from
12caeab to
ea5367f
Compare
Jordan-Nelson
approved these changes
May 9, 2022
| @@ -126,7 +126,7 @@ class AuthenticatorInputLocalizationsEn | |||
| } | |||
|
|
|||
| @override | |||
| String passwordRequirementsAtLeast(int numCharacters, String characterType) { | |||
| String passwordRequirementsAtLeast(num numCharacters, String characterType) { | |||
There was a problem hiding this comment.
Is this not always an int? I assume if it is not an int it is still a whole number?
There was a problem hiding this comment.
This was changed on one of my initial commits, and I cannot recall why. I'm changing it back. If there is an issue with it, it's immaterial to this PR.
packages/auth/amplify_auth_cognito/example/integration_test/utils/setup_utils.dart
Outdated
Show resolved
Hide resolved
packages/auth/amplify_auth_cognito/lib/method_channel_auth_cognito.dart
Outdated
Show resolved
Hide resolved
dnys1
reviewed
May 9, 2022
...ges/amplify_authenticator/example/lib/customization/authenticator_with_custom_auth_flow.dart
Show resolved
Hide resolved
packages/amplify_authenticator/example/lib/resolvers/localized_input_resolver.dart
Show resolved
Hide resolved
packages/amplify_authenticator/example/lib/resolvers/localized_title_resolver.dart
Show resolved
Hide resolved
packages/amplify_authenticator/lib/src/blocs/auth/auth_bloc.dart
Outdated
Show resolved
Hide resolved
packages/amplify_authenticator/lib/src/blocs/auth/auth_bloc.dart
Outdated
Show resolved
Hide resolved
packages/amplify_authenticator/lib/src/state/authenticator_state.dart
Outdated
Show resolved
Hide resolved
packages/amplify_authenticator/lib/src/widgets/form_fields/confirm_sign_in_form_field.dart
Outdated
Show resolved
Hide resolved
packages/auth/amplify_auth_cognito/example/integration_test/custom_auth_passwordless_test.dart
Outdated
Show resolved
Hide resolved
dnys1
reviewed
May 10, 2022
packages/amplify_authenticator/example/lib/customization/authenticator_with_custom_layout.dart
Outdated
Show resolved
Hide resolved
| @@ -75,3 +75,11 @@ class VerifyUserFlow extends UnauthenticatedState { | |||
| const VerifyUserFlow({required this.unverifiedAttributeKeys}) | |||
| : super(step: AuthenticatorStep.verifyUser); | |||
| } | |||
|
|
|||
| class ConfirmSignInCustom extends UnauthenticatedState { | |||
| final Map<dynamic, dynamic> publicParameters; | |||
There was a problem hiding this comment.
Still shows dynamic, dynamic for me
packages/amplify_authenticator/lib/src/state/authenticator_state.dart
Outdated
Show resolved
Hide resolved
| @@ -44,6 +44,14 @@ class AuthenticatorState extends ChangeNotifier { | |||
| _resetAttributes(); | |||
| } | |||
| }); | |||
|
|
|||
| // Always listen for ConfirmSignInCustom events (not distinct) | |||
There was a problem hiding this comment.
Shouldn't make a difference. distinct just means that two identical events will not be emitted back-to-back.
There was a problem hiding this comment.
Yeah - I thought that this might be needed for multiple Custom Challenges.
| /// Uses [ButtonResolverKey.confirm] for localization | ||
| /// {@endtemplate} | ||
| class ConfirmSignInCustomButton extends ConfirmSignInMFAButton { | ||
| /// {@macro amplify_authenticator.confirm_sign_custom_button} |
There was a problem hiding this comment.
Template string does not match above
packages/amplify_authenticator/lib/src/widgets/form_fields/confirm_sign_in_form_field.dart
Show resolved
Hide resolved
packages/auth/amplify_auth_cognito/example/integration_test/sign_in_sign_out_test.dart
Outdated
Show resolved
Hide resolved
packages/auth/amplify_auth_cognito/example/integration_test/custom_auth_passwordless_test.dart
Show resolved
Hide resolved
packages/auth/amplify_auth_cognito/example/tool/DefineAuthChallengeLambda/src/index.js
Outdated
Show resolved
Hide resolved
dnys1
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#410
Description of changes:
Enables custom authentication flows.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.