Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Lint fixes #1471

Merged
merged 13 commits into from
Apr 29, 2022
Merged

chore: Lint fixes #1471

merged 13 commits into from
Apr 29, 2022

Conversation

dnys1
Copy link
Contributor

@dnys1 dnys1 commented Mar 22, 2022

Issue #, if available:

Description of changes:

  • Fixes and changes needed to support analysis under Dart 2.17 and pkg:lints 2.0

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dnys1 dnys1 requested a review from a team as a code owner March 22, 2022 23:53
@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2022

Codecov Report

Merging #1471 (db3c12a) into main (8f862b3) will increase coverage by 0.17%.
The diff coverage is 45.25%.

@@            Coverage Diff             @@
##             main    #1471      +/-   ##
==========================================
+ Coverage   46.64%   46.82%   +0.17%     
==========================================
  Files         259      259              
  Lines       10153    10142      -11     
==========================================
+ Hits         4736     4749      +13     
+ Misses       5417     5393      -24     
Flag Coverage Δ
android-unit-tests ∅ <ø> (∅)
flutter-unit-tests 37.00% <45.25%> (+0.21%) ⬆️
ios-unit-tests 85.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...y_api/lib/src/graphql/graphql_request_factory.dart 95.12% <ø> (+1.52%) ⬆️
..._api/lib/src/graphql/graphql_response_decoder.dart 93.75% <ø> (+8.03%) ⬆️
...plify_authenticator/lib/amplify_authenticator.dart 0.00% <0.00%> (ø)
...ator/lib/src/mixins/authenticator_phone_field.dart 0.00% <0.00%> (ø)
...ator/lib/src/mixins/authenticator_radio_field.dart 0.00% <0.00%> (ø)
...idgets/form_fields/confirm_sign_in_form_field.dart 4.06% <0.00%> (ø)
...ib/src/widgets/form_fields/phone_number_field.dart 0.00% <0.00%> (ø)
...widgets/form_fields/reset_password_form_field.dart 6.34% <0.00%> (ø)
...ib/src/widgets/form_fields/sign_up_form_field.dart 4.49% <0.00%> (ø)
...rc/widgets/form_fields/verify_user_form_field.dart 24.39% <0.00%> (ø)
... and 34 more

@dnys1 dnys1 force-pushed the chore/lint-updates branch from 3da132e to 801f06a Compare March 29, 2022 17:10
@dnys1 dnys1 merged commit abeaafa into aws-amplify:main Apr 29, 2022
@dnys1 dnys1 deleted the chore/lint-updates branch April 29, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants