Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(auth): Templatize and update exception comments #1476

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

cshfang
Copy link
Member

@cshfang cshfang commented Mar 25, 2022

Issue #, if available: N/A

Description of changes:
This PR adds dartdocs templating to Auth Exception classes and updates their descriptions to be more

  1. Consistent/standardized relative to each other
  2. Adapted from its original exception language (e.g. Cognito exceptions)
  3. Correct, in some cases

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cshfang cshfang requested a review from a team as a code owner March 25, 2022 17:11
Copy link
Member

@HuiSF HuiSF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cshfang cshfang merged commit e33e7b7 into aws-amplify:main Mar 25, 2022
@cshfang cshfang deleted the cleanup-exceptions branch March 25, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants