fix(core): Update QueryPagination page field to default to 0 #1533
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #842
Description of changes: This PR updates the default constructor for
QueryPagination
s to supply a default value of0
for thepage
field. The Kotlin version of theQueryPaginationBuilder
checks to see if the serialized map passed to it contains thepage
key, but since theserializeAsMap()
method always adds the page key, aNullPointerException
can arise as a result.Another fix considered was to update the
serializeAsMap()
method to only add thepage
key if page is defined. This would be a reasonable fix but only when coupled with the currentQueryPaginationBuilder
utilities. Opting for the default value would not require the "is thepage
key defined check.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.