Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable dependabot #1568

Merged
merged 13 commits into from
May 11, 2022
Merged

chore: enable dependabot #1568

merged 13 commits into from
May 11, 2022

Conversation

ragingsquirrel3
Copy link
Contributor

This PR adds needed code changes to enable dependabot for dart projects. See https://github.blog/changelog/2022-04-05-pub-beta-support-for-dependabot-version-updates/ as well as linked thread where there are some questions about monorepos. Per that thread, I believe we need separate entries for all the pubspec locations, so I made a little script to generate that as I expect it to need updates when directory structure changes.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@dnys1 dnys1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Script could be cleaned up but not a major issue IMO. Can rewrite in Dart if you want and use Directory.list(recursive: true) to make it future proof.

@ragingsquirrel3 ragingsquirrel3 changed the title Feat/dependabot chore: enable dependabot May 3, 2022
@ragingsquirrel3 ragingsquirrel3 marked this pull request as ready for review May 4, 2022 17:18
@ragingsquirrel3 ragingsquirrel3 requested a review from a team as a code owner May 4, 2022 17:18
Copy link
Contributor

@haverchuck haverchuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is any annoying nit, but could we put the 'updates' block in alphabetical order?
Otherwise looks good to me.

@ragingsquirrel3
Copy link
Contributor Author

This is any annoying nit, but could we put the 'updates' block in alphabetical order? Otherwise looks good to me.

I changed the generation script to sort the output alphabetically.

@ragingsquirrel3
Copy link
Contributor Author

Looks good. Script could be cleaned up but not a major issue IMO. Can rewrite in Dart if you want and use Directory.list(recursive: true) to make it future proof.

Good suggestion, ended up converting to a dart script to do this plus some other things.

@ragingsquirrel3 ragingsquirrel3 merged commit 6cf7a93 into aws-amplify:main May 11, 2022
@ragingsquirrel3 ragingsquirrel3 deleted the feat/dependabot branch May 11, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants