Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Flutter 3 fixes #1580

Merged
merged 2 commits into from
May 11, 2022
Merged

chore: Flutter 3 fixes #1580

merged 2 commits into from
May 11, 2022

Conversation

dnys1
Copy link
Contributor

@dnys1 dnys1 commented May 11, 2022

Issue #, if available:

Description of changes:
Fixes for Flutter 3/Dart 2.17

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dnys1 dnys1 requested a review from a team as a code owner May 11, 2022 21:46
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2022

Codecov Report

Merging #1580 (60d6a2f) into main (2256175) will increase coverage by 9.47%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1580      +/-   ##
==========================================
+ Coverage   36.69%   46.17%   +9.47%     
==========================================
  Files         240      260      +20     
  Lines        8167    10237    +2070     
==========================================
+ Hits         2997     4727    +1730     
- Misses       5170     5510     +340     
Flag Coverage Δ
android-unit-tests ∅ <ø> (?)
flutter-unit-tests 36.69% <ø> (ø)
ios-unit-tests 83.57% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../example/ios/unit_tests/resources/SchemaData.swift 100.00% <0.00%> (ø)
...xample/ios/unit_tests/FlutterURLSessionTests.swift 0.00% <0.00%> (ø)
...plify_api_ios/example/ios/Runner/AppDelegate.swift 0.00% <0.00%> (ø)
...s/example/ios/unit_tests/GraphQLApiUnitTests.swift 89.50% <0.00%> (ø)
...e/ios/unit_tests/MockAnalyticsCategoryPlugin.swift 15.38% <0.00%> (ø)
.../ios/unit_tests/amplify_flutter_exampleTests.swift 94.59% <0.00%> (ø)
...ify_datastore/example/ios/Runner/AppDelegate.swift 0.00% <0.00%> (ø)
...e/example/ios/unit_tests/GetJsonFromFileUtil.swift 57.14% <0.00%> (ø)
...os/unit_tests/ModelSchemaEquatableExtensions.swift 89.83% <0.00%> (ø)
...y_flutter_ios/example/ios/Runner/AppDelegate.swift 0.00% <0.00%> (ø)
... and 10 more

@dnys1 dnys1 merged commit ac8711b into aws-amplify:main May 11, 2022
@dnys1 dnys1 deleted the chore/flutter-3-fixes branch May 11, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants