Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): OperationsManager crash #1598

Merged
merged 3 commits into from
May 17, 2022

Conversation

dnys1
Copy link
Contributor

@dnys1 dnys1 commented May 17, 2022

Issue #, if available:

Description of changes:

  • Fixes iOS crash due to concurrent access of an array
  • Enabled thread sanitizer in API unit tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dnys1 dnys1 requested a review from a team as a code owner May 17, 2022 18:52
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2022

Codecov Report

Merging #1598 (1b39a40) into main (966d9ed) will increase coverage by 1.52%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1598      +/-   ##
==========================================
+ Coverage   46.17%   47.69%   +1.52%     
==========================================
  Files         260      260              
  Lines       10237    10252      +15     
==========================================
+ Hits         4727     4890     +163     
+ Misses       5510     5362     -148     
Flag Coverage Δ
android-unit-tests ∅ <ø> (∅)
flutter-unit-tests 36.69% <ø> (ø)
ios-unit-tests 90.79% <100.00%> (+7.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...xample/ios/unit_tests/FlutterURLSessionTests.swift 87.26% <100.00%> (+87.26%) ⬆️
.../ios/unit_tests/amplify_flutter_exampleTests.swift 35.13% <0.00%> (-59.46%) ⬇️

@dnys1 dnys1 merged commit 5c6d8ea into aws-amplify:main May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants