feat(auth): runtime authFlow attribute #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haverchuck
force-pushed
the
feat/runtime-auth-type
branch
from
65804fd to
5bea8c5
Compare
dnys1
reviewed
Jun 10, 2022
| @@ -17,10 +17,13 @@ import 'package:amplify_core/amplify_core.dart'; | |||
|
|
|||
| class CognitoSignInOptions extends SignInOptions { | |||
| Map<String, String>? clientMetadata; | |||
| CognitoSignInOptions({this.clientMetadata}) : super(); | |||
| final AuthenticationFlowType? authFlowType; | |||
There was a problem hiding this comment.
How about just authFlow. The type suffix originates in the SDK where they add Type to the end of all types for some reason
There was a problem hiding this comment.
The API parameter authFlowType is what is used by the native libraries, so I decided to stay consistent with them. In terms of the enum AuthenticationFlowType, I used the existing one we are getting from the config. I realize it's a little odd to have a mismatch between the type name and the API parameter, but I didn't want to deviate from the native APIs or change/duplicate an existing enum.
haverchuck
force-pushed
the
feat/runtime-auth-type
branch
from
5bea8c5 to
aad4f4b
Compare
HuiSF
approved these changes
Jul 11, 2022
dnys1
approved these changes
Jul 11, 2022
dnys1
pushed a commit
to dnys1/amplify-flutter
that referenced
this pull request
Jul 11, 2022
To match aws-amplify#1687. commit-id:883a5e6b
dnys1
pushed a commit
that referenced
this pull request
Jul 11, 2022
To match #1687. commit-id:883a5e6b
haverchuck
added a commit
that referenced
this pull request
Jul 13, 2022
haverchuck
added a commit
that referenced
this pull request
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#334
Description of changes:
Adds runtime authFlow type. Requires bumping amplify-android to 1.34.0 and amplify-ios to 1.25.0.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.